[GitHub] [flink] zhuzhurk commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

[via GitHub]

zhuzhurk commented on code in PR #21634:
URL: https://github.com/apache/flink/pull/21634#discussion_r1222589159


##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/JobConfiguration.java:
##########
@@ -89,27 +98,67 @@ public enum JobConfiguration {
             ResultPartitionType.BLOCKING,
             JobType.BATCH,
             ExecutionMode.BATCH,
+            SchedulerType.Default,
             10,
-            true);
+            true),
+
+    ADAPTIVE_BATCH(
+            DistributionPattern.ALL_TO_ALL,
+            ResultPartitionType.BLOCKING,
+            JobType.BATCH,
+            ExecutionMode.BATCH,
+            SchedulerType.AdaptiveBatch,
+            4000,
+            false),
+
+    ADAPTIVE_BATCH_HYBRID(
+            DistributionPattern.ALL_TO_ALL,
+            ResultPartitionType.HYBRID_FULL,

Review Comment:
   Correction: It's not needed because there is no difference between 
HYBRID_FULL  and HYBRID_SELECTIVE in the scheduling stage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org