Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1209910623
########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.filemerging; + +import org.apache.flink.api.common.TaskInfo; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.state.CheckpointedStateScope; + +import java.io.Closeable; +import java.io.IOException; + +/** + * Manages meta information in TM side when taking file-merging checkpoints. It provides interfaces + * to manipulate files. + * + * <p>TODO (FLINK-32073): create output stream. + * + * <p>TODO (FLINK-32075): leverage checkpoint notification to delete logic files. + */ +public interface FileMergingSnapshotManager extends Closeable { + + /** + * Init the file system if needed. This includes creating the managed directory for file-merging + * + * @param fileSystemInfo the packed file system information. + * @throws IOException thrown if anything goes wrong with file system. + */ + void initFileSystem(FileMergingCheckpointUtils.SnapshotFileSystemInfo fileSystemInfo) + throws IOException; + + /** + * Register a subtask and create the managed directory for shared states. + * + * @param subtaskKey the subtask key identifying a subtask. + */ + void addSubtask(SubtaskKey subtaskKey); + + /** Return the working directory of the segment snapshot manager. */ Review Comment: No other meaning, I changed the statement here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
