[GitHub] [flink] WencongLiu commented on a diff in pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

[via GitHub]

WencongLiu commented on code in PR #22579:
URL: https://github.com/apache/flink/pull/22579#discussion_r1206739358


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/SemiJoinITCase.scala:
##########
@@ -470,7 +469,7 @@ class SemiJoinITCase(expectedJoinType: JoinType) extends 
BatchTestBase {
 }
 
 object SemiJoinITCase {
-  @Parameterized.Parameters(name = "{0}-{1}")
+  @Parameters(name = "{0}-{1}")

Review Comment:
   Yes. There is one parameter. 



##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala:
##########
@@ -1333,7 +1335,7 @@ class JoinITCase(expectedJoinType: JoinType) extends 
BatchTestBase {
 }
 
 object JoinITCase {
-  @Parameterized.Parameters(name = "{0}")
+  @Parameters(name = "{0}")

Review Comment:
   If the "name" is modified to "expectedJoinType". It can't be compiled 
successfully.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org