rodmeneses commented on code in PR #575:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/575#discussion_r1179342548
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -113,7 +115,13 @@ public boolean scale(FlinkResourceContext<? extends
AbstractFlinkResource<?, ?>>
scalingExecutor.scaleResource(resource, autoScalerInfo,
conf, evaluatedMetrics);
autoScalerInfo.replaceInKubernetes(kubernetesClient);
return specAdjusted;
- } catch (Exception e) {
+ } catch (Throwable e) {
+ eventRecorder.triggerEvent(
+ resource,
+ EventRecorder.Type.Warning,
+ EventRecorder.Reason.AutoscalerError,
+ EventRecorder.Component.Operator,
+ e.getMessage());
Review Comment:
Maybe we can add a unit test to cover this, just to be 100% sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
