zhipeng93 commented on code in PR #215:
URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168135056
##########
flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java:
##########
@@ -468,7 +425,9 @@ public void initializeState(StreamTaskStateInitializer
streamTaskStateManager)
timeServiceManager =
streamOperatorStateContext.internalTimerServiceManager();
- broadcastVariablesReady = false;
+ if (richContext.hasRichFunction) {
+ richContext.broadcastVariablesReady = false;
Review Comment:
Logically if `hasRichFunction == false`, we will never access the value of
`broadcastVariablesReady`. So it seems unnecessary to set the value here.
But thanks for the catch, I found it unnecessary to call this function here
since it is always initialized in `RichContext`.
I will remove these three lines later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
