vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1149125548
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception>
throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
yes, I think it should return `false` if `chainedClassifier` is `null`, it's
not because null `chainedClassifier` can cause fatal exception, it's because we
should maintain/keep the `false` result after the `validator.test` returns
`false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
