[
https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585538#comment-15585538
]
ASF GitHub Bot commented on FLINK-4851:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2655
[FLINK-4851] [rm] Introduce FatalErrorHandler and MetricRegistry to RM
This PR is based on #2651
This PR introduces a `FatalErrorHandler` and the `MetricRegistry` to the
RM. The `FatalErrorHandler` is used to handle fatal errors. Additionally, the
PR adds the `MetricRegistry` to the RM which can be used to register metrics.
Apart from these changes the PR restructures the code of the RM a little
bit and fixes some
blocking operations.
The PR also moves the `TestingFatalErrorHandler` into the util package of
flink-runtime test. That way, it is usable across multiple tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink resourceManagerImprovements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2655.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2655
----
commit ddf35c4ddb04629cddebb2401488effe93416b70
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2016-10-17T14:22:16Z
[FLINK-4847] Let RpcEndpoint.start/shutDown throw exceptions
Allowing the RpcEndpoint.start/shutDown to throw exceptions will help to
let rpc endpoints
to quickly fail without having to use a callback like the FatalErrorHandler.
commit 9fdcc11f7730b3c7a6f061c17d0463ea3f21a9f9
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2016-10-17T14:03:02Z
[FLINK-4851] [rm] Introduce FatalErrorHandler and MetricRegistry to RM
This PR introduces a FatalErrorHandler and the MetricRegistry to the RM.
The FatalErrorHandler is used to handle fatal errors. Additionally, the PR adds
the MetricRegistry to the RM which can be used
to register metrics.
Apart from these changes the PR restructures the code of the RM a little
bit and fixes some
blocking operations.
The PR also moves the TestingFatalErrorHandler into the util package of
flink-runtime test. That
it is usable across multiple tests.
----
> Add FatalErrorHandler and MetricRegistry to ResourceManager
> -----------------------------------------------------------
>
> Key: FLINK-4851
> URL: https://issues.apache.org/jira/browse/FLINK-4851
> Project: Flink
> Issue Type: Sub-task
> Components: ResourceManager
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{ResourceManager}} currently does not contain a {{FatalErrorHandler}}.
> In order to harmonize the fatal error handling across all components, we
> should introduce a {{FatalErrorHandler}}, which handles fatal errors.
> Additionally, we should also give a {{MetricRegistry}} to the
> {{ResourceManager}} so that it can report metrics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
