LadyForest commented on code in PR #22222:
URL: https://github.com/apache/flink/pull/22222#discussion_r1144149500
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdWindowProperties.scala:
##########
@@ -252,13 +254,40 @@ class FlinkRelMdWindowProperties private extends
MetadataHandler[FlinkMetadata.W
}
def getWindowProperties(
- rel: StreamPhysicalWindowAggregate,
+ rel: StreamPhysicalWindowAggregateBase,
mq: RelMetadataQuery): RelWindowProperties = {
+ rel match {
+ case _: StreamPhysicalWindowAggregate =>
+ val aggregate = rel.asInstanceOf[StreamPhysicalWindowAggregate]
+ getWindowAggregateWindowProperties(
+ aggregate.grouping.length + aggregate.aggCalls.size(),
+ aggregate.namedWindowProperties,
+ aggregate.windowing.getWindow,
+ aggregate.windowing.getTimeAttributeType
+ )
+ case _: StreamPhysicalGlobalWindowAggregate =>
+ val aggregate = rel.asInstanceOf[StreamPhysicalGlobalWindowAggregate]
+ getWindowAggregateWindowProperties(
+ aggregate.grouping.length + aggregate.aggCalls.size(),
+ aggregate.namedWindowProperties,
+ aggregate.windowing.getWindow,
+ aggregate.windowing.getTimeAttributeType
+ )
+ case _ =>
Review Comment:
`StreamPhysicalGroupWindowAggregateBase` is a base class for
`StreamPhysicalGroupWindowAggregate` &
`StreamPhysicalGlobalGroupWindowAggregate`.
The input of window join might be `StreamPhysicalGroupWindowAggregate` or
`StreamPhysicalGlobalGroupWindowAggregate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
