[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

[via GitHub]

dmvk commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1140236168


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1050,6 +1055,14 @@ public CreatingExecutionGraph.AssignmentResult 
tryToAssignSlots(
                 
.orElseGet(CreatingExecutionGraph.AssignmentResult::notPossible);
     }
 
+    @Override
+    public void freeExcessiveReservedSlots() {
+        for (SlotInfo slotInfo : 
declarativeSlotPool.getFreeSlotsInformation()) {
+            declarativeSlotPool.freeReservedSlot(
+                    slotInfo.getAllocationId(), null, 
System.currentTimeMillis());
+        }

Review Comment:
   (tests are still passing after removing this)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org