PatrickRen commented on code in PR #22202:
URL: https://github.com/apache/flink/pull/22202#discussion_r1140027906
##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -115,6 +115,10 @@ under the License.
<pattern>com.google</pattern>
<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
</relocation>
+ <relocation>
+
<pattern>org.apache.commons.lang3</pattern>
+
<shadedPattern>org.apache.flink.hive.shaded.org.apache.commons.lang3</shadedPattern>
Review Comment:
What about relocating the entire `org.apache.commons` package? I listed the
entire dependency tree and found some other Apache Commons libs, not just
common3.
##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -115,6 +115,10 @@ under the License.
<pattern>com.google</pattern>
<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
</relocation>
+ <relocation>
Review Comment:
I found some other packages that might lead to potential conflicts. Maybe
you can relocate them in one shot:
- org.joda.time
- com.fasterxml.jackson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
