zentol commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1137277106
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -216,11 +218,16 @@
private final DeploymentStateTimeMetrics deploymentTimeMetrics;
private final BoundedFIFOQueue<RootExceptionHistoryEntry> exceptionHistory;
+ private JobGraphJobInformation jobInformation;
+ private ResourceCounter desiredResources = ResourceCounter.empty();
private final JobManagerJobMetricGroup jobManagerJobMetricGroup;
+ private final Duration slotIdleTimeout;
+
Review Comment:
It's the slot timeout, but it's being used as an interval.
If you'd name it "interval" then you'd have to wonder what this is interval
is based on.
I'd keep it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
