[GitHub] [flink] zhuzhurk commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.

[via GitHub]

zhuzhurk commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1125915973


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -35,7 +35,7 @@
 
 /**
  * Default implementation of {@link PreferredLocationsRetriever}. Locations 
based on state will be
- * returned if exist. Otherwise locations based on inputs will be returned.
+ * returned if existed. Otherwise, locations based on inputs will be returned.

Review Comment:
   The usage of `exist` is correct regarding `locations`.
   
   And I would suggest to not make this kind of changes, if the statement was 
not misleading or incorrect, unless you need to update the statement because it 
is outdated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org