reswqa opened a new pull request, #22067:
URL: https://github.com/apache/flink/pull/22067
## What is the purpose of the change
*Only pipelined / pipelined-bounded partition needs overdraft buffer. More
specifically, there is no reason to request more buffers for non-pipelined
(i.e. batch) shuffle. The reasons are as follows:*
- *For BoundedBlockingShuffle, each full buffer will be directly released.*
- *For SortMergeShuffle, the maximum capacity of buffer pool is 4 *
numSubpartitions. It is efficient enough to spill this part of memory to disk.*
- *For Hybrid Shuffle, the buffer pool is unbounded. If it can't get a
normal buffer, it also can't get an overdraft buffer.*
## Brief change log
- *Disable overdraft buffer for non pipelined result partition.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
