FangYongs commented on code in PR #564: URL: https://github.com/apache/flink-table-store/pull/564#discussion_r1119841157
########## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/stats/FieldStatsConverters.java: ########## @@ -33,12 +33,14 @@ public class FieldStatsConverters { private final Function<Long, List<DataField>> schemaFields; private final long tableSchemaId; + private final List<DataField> tableDataFields; private final ConcurrentMap<Long, FieldStatsArraySerializer> serializers; private final AtomicReference<List<DataField>> tableFields; public FieldStatsConverters(Function<Long, List<DataField>> schemaFields, long tableSchemaId) { this.schemaFields = schemaFields; this.tableSchemaId = tableSchemaId; Review Comment: We can remove tableSchemaId here if we get table data fields in the constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org