XComp commented on code in PR #21736:
URL: https://github.com/apache/flink/pull/21736#discussion_r1118824273
##########
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java:
##########
@@ -263,14 +268,17 @@ void generateTestSetupFiles(
DataOutputSerializer testDataOut = new
DataOutputSerializer(INITIAL_OUTPUT_BUFFER_SIZE);
priorSerializer.serialize(testSpecification.setup.createTestData(),
testDataOut);
writeContentsTo(
- getGenerateDataFilePath(testSpecification),
testDataOut.getCopyOfBuffer());
+ getGenerateDataFilePath(testSpecification,
testSpecification.flinkVersion),
Review Comment:
```suggestion
getGenerateDataFilePath(testSpecification),
```
The second parameter is obsolete.
##########
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java:
##########
@@ -66,7 +58,22 @@
* Creates a collection of {@link TestSpecification} which will be used as
input for
* parametrized tests.
*/
- public abstract Collection<TestSpecification<?, ?>>
createTestSpecifications() throws Exception;
+ public abstract Collection<TestSpecification<?, ?>>
createTestSpecifications(
Review Comment:
yikes, good catch. :-D that's a nasty one. The `getGenerate*FilePath`
methods used `CURRENT_VERSION` as well instead of the version of the
`testSpecification` parameter.
##########
flink-test-utils-parent/flink-migration-test-utils/README.md:
##########
@@ -0,0 +1,93 @@
+# Add State Migration Tests
+
+This module is the tools that helps the state migration tests
+generate the snapshots of the current version before cutting branch.
+
+To add a state migration tests in one module, add the following dependency
+
+```xml
+
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>fink-migration-test-utils</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+</dependency>
+```
+
+and the following profile
+
+```xml
+<profile>
+ <id>generate-snapshots</id>
Review Comment:
I'd go for `generate-migration-test-data`. "data" is already plural - adding
the plural to the "test" keyword doesn't add any value but is rather unusual,
in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
