[
https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated FLINK-31142:
------------------------------------
Description:
Although the behavior has been changed in 1.17.0, I'm not sure whether it is a
blocker or not, since in both cases it is invalid query.
The difference in the behavior is that before 1.17.0
a query like
{code:sql}
select /* multiline comment;
{code}
fails to execute and sql client prompts to submit another query.
In 1.17.0 it shuts down the session failing with
{noformat}
Exception in thread "main" org.apache.flink.table.client.SqlClientException:
Could not read from command line.
at
org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:205)
at
org.apache.flink.table.client.cli.CliClient.executeInteractive(CliClient.java:168)
at
org.apache.flink.table.client.cli.CliClient.executeInInteractiveMode(CliClient.java:113)
at org.apache.flink.table.client.SqlClient.openCli(SqlClient.java:169)
at org.apache.flink.table.client.SqlClient.start(SqlClient.java:118)
at
org.apache.flink.table.client.SqlClient.startClient(SqlClient.java:228)
at org.apache.flink.table.client.SqlClient.main(SqlClient.java:179)
Caused by: org.apache.flink.sql.parser.impl.TokenMgrError: Lexical error at
line 1, column 29. Encountered: <EOF> after : ""
at
org.apache.flink.sql.parser.impl.FlinkSqlParserImplTokenManager.getNextToken(FlinkSqlParserImplTokenManager.java:26752)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.scan(SqlCommandParserImpl.java:89)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.next(SqlCommandParserImpl.java:81)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.checkIncompleteStatement(SqlCommandParserImpl.java:141)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.getCommand(SqlCommandParserImpl.java:111)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.parseStatement(SqlCommandParserImpl.java:52)
at
org.apache.flink.table.client.cli.parser.SqlMultiLineParser.parse(SqlMultiLineParser.java:82)
at
org.jline.reader.impl.LineReaderImpl.acceptLine(LineReaderImpl.java:2964)
at
org.jline.reader.impl.LineReaderImpl$1.apply(LineReaderImpl.java:3778)
at
org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:679)
at
org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:183)
... 6 more
Shutting down the session...
done.
{noformat}
was:
Although the behavior has been changed in 1.17.0, I'm not sure whether it is a
blocker or not, since in both cases it is invalid query.
The difference in the behavior is that before 1.17.0
a query like
{code:sql}
select /* multiline comment;
{code}
fails to execute and sql client prompts to submit another query.
In 1.17.0 it fails with
{noformat}
Exception in thread "main" org.apache.flink.table.client.SqlClientException:
Could not read from command line.
at
org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:205)
at
org.apache.flink.table.client.cli.CliClient.executeInteractive(CliClient.java:168)
at
org.apache.flink.table.client.cli.CliClient.executeInInteractiveMode(CliClient.java:113)
at org.apache.flink.table.client.SqlClient.openCli(SqlClient.java:169)
at org.apache.flink.table.client.SqlClient.start(SqlClient.java:118)
at
org.apache.flink.table.client.SqlClient.startClient(SqlClient.java:228)
at org.apache.flink.table.client.SqlClient.main(SqlClient.java:179)
Caused by: org.apache.flink.sql.parser.impl.TokenMgrError: Lexical error at
line 1, column 29. Encountered: <EOF> after : ""
at
org.apache.flink.sql.parser.impl.FlinkSqlParserImplTokenManager.getNextToken(FlinkSqlParserImplTokenManager.java:26752)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.scan(SqlCommandParserImpl.java:89)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.next(SqlCommandParserImpl.java:81)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.checkIncompleteStatement(SqlCommandParserImpl.java:141)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.getCommand(SqlCommandParserImpl.java:111)
at
org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.parseStatement(SqlCommandParserImpl.java:52)
at
org.apache.flink.table.client.cli.parser.SqlMultiLineParser.parse(SqlMultiLineParser.java:82)
at
org.jline.reader.impl.LineReaderImpl.acceptLine(LineReaderImpl.java:2964)
at
org.jline.reader.impl.LineReaderImpl$1.apply(LineReaderImpl.java:3778)
at
org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:679)
at
org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:183)
... 6 more
Shutting down the session...
done.
{noformat}
And it shuts down the sessoin
> Some queries lead to abrupt sql client close
> --------------------------------------------
>
> Key: FLINK-31142
> URL: https://issues.apache.org/jira/browse/FLINK-31142
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Client
> Affects Versions: 1.17.0
> Reporter: Sergey Nuyanzin
> Priority: Major
> Labels: release-testing
>
> Although the behavior has been changed in 1.17.0, I'm not sure whether it is
> a blocker or not, since in both cases it is invalid query.
> The difference in the behavior is that before 1.17.0
> a query like
> {code:sql}
> select /* multiline comment;
> {code}
> fails to execute and sql client prompts to submit another query.
> In 1.17.0 it shuts down the session failing with
> {noformat}
> Exception in thread "main" org.apache.flink.table.client.SqlClientException:
> Could not read from command line.
> at
> org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:205)
> at
> org.apache.flink.table.client.cli.CliClient.executeInteractive(CliClient.java:168)
> at
> org.apache.flink.table.client.cli.CliClient.executeInInteractiveMode(CliClient.java:113)
> at org.apache.flink.table.client.SqlClient.openCli(SqlClient.java:169)
> at org.apache.flink.table.client.SqlClient.start(SqlClient.java:118)
> at
> org.apache.flink.table.client.SqlClient.startClient(SqlClient.java:228)
> at org.apache.flink.table.client.SqlClient.main(SqlClient.java:179)
> Caused by: org.apache.flink.sql.parser.impl.TokenMgrError: Lexical error at
> line 1, column 29. Encountered: <EOF> after : ""
> at
> org.apache.flink.sql.parser.impl.FlinkSqlParserImplTokenManager.getNextToken(FlinkSqlParserImplTokenManager.java:26752)
> at
> org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.scan(SqlCommandParserImpl.java:89)
> at
> org.apache.flink.table.client.cli.parser.SqlCommandParserImpl$TokenIterator.next(SqlCommandParserImpl.java:81)
> at
> org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.checkIncompleteStatement(SqlCommandParserImpl.java:141)
> at
> org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.getCommand(SqlCommandParserImpl.java:111)
> at
> org.apache.flink.table.client.cli.parser.SqlCommandParserImpl.parseStatement(SqlCommandParserImpl.java:52)
> at
> org.apache.flink.table.client.cli.parser.SqlMultiLineParser.parse(SqlMultiLineParser.java:82)
> at
> org.jline.reader.impl.LineReaderImpl.acceptLine(LineReaderImpl.java:2964)
> at
> org.jline.reader.impl.LineReaderImpl$1.apply(LineReaderImpl.java:3778)
> at
> org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:679)
> at
> org.apache.flink.table.client.cli.CliClient.getAndExecuteStatements(CliClient.java:183)
> ... 6 more
> Shutting down the session...
> done.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
