tamirsagi commented on code in PR #531:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/531#discussion_r1111250574
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -53,13 +53,13 @@ spec:
flinkVersion: v1_16
flinkConfiguration:
taskmanager.numberOfTaskSlots: "2"
+ serviceAccount: flink
podTemplate:
apiVersion: v1
kind: Pod
metadata:
name: pod-template
spec:
- serviceAccount: flink
Review Comment:
Once its there it fails upon validation.
https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java#L98
https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java#L523
It has to be in the outer 'spec' level to get the deployment to work.
unless the intention was
validateServiceAccount(spec.getPodTemplate().getSpec().getServiceAccount()));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
