liuyongvs commented on PR #21958:
URL: https://github.com/apache/flink/pull/21958#issuecomment-1434909262
> Thanks for your contribution.
>
> To be honest i didn't get the logic. What i did:
>
> 1. Built it from the PR's branch
> 2. Started standalone Flink
> 3. Via sqlClient submitted several queries
>
> ```sql
> SELECT array_union(array[1], array[2]);
> -- result array[1, 2]
> -- this is OK
> ```
>
> ```sql
> SELECT array_union(array[1], array[2, 3]);
> -- result array[1, 2, 3]
> --- this is OK
> ```
>
> ```sql
> SELECT array_union(array[1], array[2, 3, null]);
> -- result array[1, 2, 3, 0]
> --- this is NOT OK
> ```
>
> ```sql
> SELECT array_union(array[1], array[map['this is a key', 'this is a
value']]);
> -- result [1, 68]
> -- this is NOT OK
> ```
>
> ```sql
> SELECT array_union(array[1], array['this is a string']);
> -- result [1, 16]
> -- this is NOT OK
> ```
>
> ```sql
> SELECT array_union(array[1], array[array[1, 2, 3]]);
> -- result [1, 24]
> -- this is NOT OK
> ```
the result is not ok like SELECT array_union(array[1], array[array[1, 2,
3]]); SELECT array_union(array[1], array['this is a string']); i said before
this two array type should be exception. we should do it like ARRAY_CONCAT is
calcite. but i do not find a good way to express it in flink. so i ask you do
you have a good implements and it is important for other array op like
array_except/array_intersect..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
