[ 
https://issues.apache.org/jira/browse/FLINK-30109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689835#comment-17689835
 ] 

Yufan Sheng commented on FLINK-30109:
-------------------------------------

[~mapohl] Can we close this issue now?

> Checked exceptions are sneakingly transformed into unchecked exceptions in 
> the Pulsar
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-30109
>                 URL: https://issues.apache.org/jira/browse/FLINK-30109
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Connectors / Pulsar, Documentation
>    Affects Versions: 1.16.0, 1.17.0, 1.15.2
>            Reporter: Matthias Pohl
>            Assignee: Yufan Sheng
>            Priority: Major
>              Labels: pull-request-available
>
> [PulsarExceptionUtils|https://github.com/apache/flink/blob/c675f786c51038801161e861826d1c54654f0dde/flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarExceptionUtils.java#L33]
>  provides {{sneaky*}} utility methods for hiding checked exceptions. This is 
> rather unusual coding. Based on what's provided in the code I would have 
> concerns as a reader that we're not handling errors properly in calling code.
> Either, we remove these methods and add proper exception handling or we add 
> proper documentation on why this workaround is necessary.
> [~syhily] already hinted in his [FLINK-29830 PR 
> comment|https://github.com/apache/flink/pull/21252#discussion_r1019822514] 
> that this is related to flaws of the Pulsar API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to