[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689097#comment-17689097 ]
xiaogang zhou commented on FLINK-31089: --------------------------------------- [~yunta] master, please kindly review. I have also tested the performance. disable PinTopLevelIndexAndFilter can significantly decrease performance disable PinL0FilterAndIndexBlocksInCache does not harm performance a lot. [https://github.com/facebook/rocksdb/issues/4112#issuecomment-405859006] also mentioned, cache top level is enough. as rocksdb memory growing issue has a lot complain in rocksdb issues > pin L0 index in memory can lead to slow memory grow finally lead to memory > beyond limit > --------------------------------------------------------------------------------------- > > Key: FLINK-31089 > URL: https://issues.apache.org/jira/browse/FLINK-31089 > Project: Flink > Issue Type: Improvement > Components: Runtime / State Backends > Affects Versions: 1.16.1 > Reporter: xiaogang zhou > Priority: Major > Attachments: image-2023-02-15-20-26-58-604.png, > image-2023-02-15-20-32-17-993.png > > > with the setPinL0FilterAndIndexBlocksInCache true, we can see the pinned > memory kept growing(in the pc blow from 48G-> 50G). But if we switch it to > false, we can see the pinned memory stay static. In our environment, a lot of > tasks restart due to memory over limit killed by k8s > !image-2023-02-15-20-26-58-604.png|width=899,height=447! > > !image-2023-02-15-20-32-17-993.png|width=853,height=464! > -- This message was sent by Atlassian Jira (v8.20.10#820010)