fsk119 commented on code in PR #21912:
URL: https://github.com/apache/flink/pull/21912#discussion_r1104041538


##########
docs/content/docs/dev/table/sql/show.md:
##########
@@ -747,4 +748,14 @@ Show all added jars in the session classloader which are 
added by [`ADD JAR`]({{
 
 <span class="label label-danger">Attention</span> Currently `SHOW JARS` only 
works in the [SQL CLI]({{< ref "docs/dev/table/sqlClient" >}}).
 
+## SHOW JOBS
+
+```sql
+SHOW JOBS
+```
+
+Show the jobs in the Flink cluster.
+
+<span class="label label-danger">Attention</span> Currently `SHOW JARS` only 
works in the [SQL CLI]({{< ref "docs/dev/table/sqlClient" >}}).

Review Comment:
   SHOW JARS/SHOW JOBS both work in the SQL Gateway && SQL Client



##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -812,4 +812,35 @@ Flink SQL> RESET pipeline.name;
 
 If the option `pipeline.name` is not specified, SQL Client will generate a 
default name for the submitted job, e.g. `insert-into_<sink_table_name>` for 
`INSERT INTO` statements.
 
+### Monitoring job status
+
+SQL Client supports to list jobs status in the cluster through `SHOW JOBS` 
statements.
+
+```sql
+Flink SQL> SHOW JOBS;
++----------------------------------+---------------+----------+-------------------------+
+|                           job id |      job name |   status |              
start time |
++----------------------------------+---------------+----------+-------------------------+
+| 228d70913eab60dda85c5e7f78b5782c | kafka-to-hive |  RUNNING | 
2023-02-11T05:03:51.523 |
++----------------------------------+---------------+----------+-------------------------+
+```
+
+### Terminating a job
+
+SQL client supports to stop jobs with or without savepoints through `STOP JOB` 
statements.

Review Comment:
   Use `SQL Client` rather than `SQL client` to align with the style.



##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -812,4 +812,35 @@ Flink SQL> RESET pipeline.name;
 
 If the option `pipeline.name` is not specified, SQL Client will generate a 
default name for the submitted job, e.g. `insert-into_<sink_table_name>` for 
`INSERT INTO` statements.
 
+### Monitoring job status

Review Comment:
   Please also modify the expression about the management of the job lifecycle 
here.
   
![image](https://user-images.githubusercontent.com/33114724/218389489-6b17e64b-0f52-4e53-b84b-2ab5e06ca7af.png)
   



##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -812,4 +812,35 @@ Flink SQL> RESET pipeline.name;
 
 If the option `pipeline.name` is not specified, SQL Client will generate a 
default name for the submitted job, e.g. `insert-into_<sink_table_name>` for 
`INSERT INTO` statements.
 
+### Monitoring job status

Review Comment:
   I think we can merge these two parts into one section like `Managing job 
lifecycle` and link to the specified page about this.



##########
docs/content/docs/dev/table/sql/jar.md:
##########
@@ -94,6 +94,6 @@ REMOVE JAR '<path_to_filename>.jar'
 
 Remove the specified jar that is added by the [`ADD JAR`](#add-jar) statements.
 
-<span class="label label-danger">Attention</span> REMOVE JAR statement only 
work in the [SQL CLI]({{< ref "docs/dev/table/sqlClient" >}}).
+<span class="label label-danger">Attention</span> REMOVE JAR statements only 
work in [SQL CLI]({{< ref "docs/dev/table/sqlClient" >}}) or [SQL Gateway]({{< 
ref "docs/dev/table/sql-gateway/overview" >}}).

Review Comment:
   SQL Gateway still doesn't support REMOVE JAR now. I think we can use the 
origin statement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to