[
https://issues.apache.org/jira/browse/FLINK-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565665#comment-15565665
]
ASF GitHub Bot commented on FLINK-3706:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2622#discussion_r82809975
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -599,15 +602,23 @@ protected void runWithArgs(String[] args, String
terminateAfterString, String[]
break;
}
}
+ if(runner.getRunnerError() != null) {
+ break; // leave loop to send output and fail
with error.
+ }
}
while (!expectedStringSeen && System.currentTimeMillis() <
deadline);
sendOutput();
+
+ if(runner.getRunnerError() != null) {
+ // this lets the test fail.
+ throw new RuntimeException("Runner failed",
runner.getRunnerError());
+ }
Assert.assertTrue("During the timeout period of " +
START_TIMEOUT_SECONDS + " seconds the " +
"expected string did not show up",
expectedStringSeen);
// check for 0 return code
- Assert.assertEquals("Expected return value", returnCode,
runner.getReturnValue());
+ Assert.assertEquals("Expected return value",
expectedReturnValue, runner.getReturnValue());
--- End diff --
This check is duplicate because it is already performed in the `Runner`.
> YARNSessionCapacitySchedulerITCase.testNonexistingQueue unstable
> ----------------------------------------------------------------
>
> Key: FLINK-3706
> URL: https://issues.apache.org/jira/browse/FLINK-3706
> Project: Flink
> Issue Type: Bug
> Reporter: Aljoscha Krettek
> Assignee: Robert Metzger
> Priority: Critical
> Labels: test-stability
> Attachments: log.txt
>
>
> I encountered a failed test on travis.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
