rkhachatryan commented on code in PR #21812:
URL: https://github.com/apache/flink/pull/21812#discussion_r1101496489
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/TaskChangelogRegistry.java:
##########
@@ -46,29 +46,29 @@
@Internal
public interface TaskChangelogRegistry {
- /** Start tracking the state uploaded for the given backends. */
- void startTracking(StreamStateHandle handle, Set<UUID> backendIDs);
+ /** Start tracking the state uploaded. */
+ void startTracking(StreamStateHandle handle, long refCount);
Review Comment:
`refCount` refers to the number of `StateChangeSet`, right?
Should we clarify that in the javadoc here?
(and that `release` should be called once per `StateChangeSet`)
I think that would make it easier to check whether `release` is called the
corresponding number of times.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
