hlteoh37 commented on code in PR #21770:
URL: https://github.com/apache/flink/pull/21770#discussion_r1101136689

##########
flink-python/src/main/java/org/apache/flink/python/env/AbstractPythonEnvironmentManager.java:
##########
@@ -166,6 +166,14 @@ public Map<String, String> 
constructEnvironmentVariables(String baseDirectory)
 
         constructFilesDirectory(env, baseDirectory);
 
+        if (this.dependencyInfo.getPythonPath() != null) {
+            List<String> configuredPythonPath = new ArrayList<>();
+            configuredPythonPath.add(this.dependencyInfo.getPythonPath());
+            appendToPythonPath(env, configuredPythonPath);

Review Comment:
   IS the PYTHONPATH used elsewhere? Will this affect any other path resolution 
on the TM?



##########
flink-python/src/main/java/org/apache/flink/python/PythonOptions.java:
##########
@@ -151,6 +151,14 @@ public class PythonOptions {
                                     + "Please ensure that the specified 
environment meets the above requirements. The "
                                     + "option is equivalent to the command 
line option \"-pyexec\".");
 
+    public static final ConfigOption<String> PYTHON_PATH =
+            ConfigOptions.key("env.PYTHONPATH")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Specify the path on the Worker Node where the 
Flink Python Dpenencies are installed which "

Review Comment:
   ```suggestion
                               "Specify the path on the Worker Node where the 
Flink Python Dependencies are installed which "
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to