reta commented on code in PR #5:
URL: 
https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1100154895


##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchAsyncSink.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.opensearch.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.connector.base.sink.AsyncSinkBase;
+import org.apache.flink.connector.base.sink.writer.BufferedRequestState;
+import org.apache.flink.connector.base.sink.writer.ElementConverter;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+
+import org.apache.http.HttpHost;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+
+import static org.apache.flink.util.Preconditions.checkArgument;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Apache Flink's Async Sink to insert or update data in an Opensearch index 
(see please {@link
+ * OpensearchAsyncWriter}).
+ *
+ * @param <InputT> type of the records converted to Opensearch actions 
(instances of {@link
+ *     DocSerdeRequest})
+ * @see OpensearchAsyncSinkBuilder on how to construct a OpensearchAsyncSink
+ */
+@PublicEvolving
+public class OpensearchAsyncSink<InputT> extends AsyncSinkBase<InputT, 
DocSerdeRequest<?>> {
+    private static final long serialVersionUID = 1L;
+
+    private final List<HttpHost> hosts;
+    private final NetworkClientConfig networkClientConfig;
+
+    /**
+     * Constructor creating an Opensearch async sink.
+     *
+     * @param maxBatchSize the maximum size of a batch of entries that may be 
sent
+     * @param maxInFlightRequests he maximum number of in flight requests that 
may exist, if any
+     *     more in flight requests need to be initiated once the maximum has 
been reached, then it
+     *     will be blocked until some have completed
+     * @param maxBufferedRequests the maximum number of elements held in the 
buffer, requests to add
+     *     elements will be blocked while the number of elements in the buffer 
is at the maximum
+     * @param maxBatchSizeInBytes the maximum size of a batch of entries that 
may be sent to KDS

Review Comment:
   :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to