echauchot commented on code in PR #3:
URL:
https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1100135736
##########
flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplit.java:
##########
@@ -48,6 +52,30 @@ public CassandraSplitState toSplitState() {
return new CassandraSplitState(new HashSet<>(ringRanges), splitId());
}
+ public void serialize(ObjectOutputStream objectOutputStream) throws
IOException {
Review Comment:
this method can be package private only if it resides in the serializer and
it makes sense that it takes a CassandraSplit instance only if it resides in
the serializer. So I'll move the method and make it static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
