[GitHub] [flink-table-store] zjureel commented on a diff in pull request #484: [FLINK-30516] Introduce files table in table store

[via GitHub]

zjureel commented on code in PR #484:
URL: https://github.com/apache/flink-table-store/pull/484#discussion_r1092873558


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AppendOnlyFileStoreScan.java:
##########
@@ -102,25 +101,6 @@ protected boolean filterByStats(ManifestEntry entry) {
     /** Note: Keep this thread-safe. */
     private FieldStatsArraySerializer getFieldStatsArraySerializer(long 
schemaId) {
         return schemaRowStatsConverters.computeIfAbsent(

Review Comment:
   I think it's cool, I indeed found there are two caches in the `StoreScan`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org