wuchong commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1089976671
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
+ key("table.display.max-column-width")
+ .intType()
+ .defaultValue(30)
+ .withDescription(
+ "When printing the query results to the client
console, this parameter determines the number of characters shown on screen
before truncating."
Review Comment:
Add a blank at the end.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
+ key("table.display.max-column-width")
+ .intType()
+ .defaultValue(30)
+ .withDescription(
+ "When printing the query results to the client
console, this parameter determines the number of characters shown on screen
before truncating."
+ + "This only applies to columns with
variable-length types (e.g. STRING) in both batch and streaming mode."
Review Comment:
Add a blank at the end.
##########
docs/layouts/shortcodes/generated/sql_client_configuration.html:
##########
@@ -8,12 +8,6 @@
</tr>
</thead>
<tbody>
- <tr>
Review Comment:
Can we remove the documentation when the configuration is totally dropped? I
think it is helpful to highlight this configuration is deprecated and please
use "table.display.max-column-width" instead. This can make the migration
smoother.
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java:
##########
@@ -54,11 +55,13 @@ private SqlClientOptions() {}
// Display options
- @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ @Deprecated
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
Review Comment:
There are still several places (e.g., `ResultDescriptor#maxColumnWidth`)
using this configuration. Could you update to use
`TableConfigOptions.DISPLAY_MAX_COLUMN_WIDTH` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
