echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1089034416
########## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraRow.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.cassandra.source.reader; + +import org.apache.flink.connector.cassandra.source.split.RingRange; + +import com.datastax.driver.core.ExecutionInfo; +import com.datastax.driver.core.Row; + +/** + * Wrapper for Cassandra {@link Row} that stores associated {@link RingRange} to be able to update + * split states. It also stores {@link ExecutionInfo} Cassandra statistics about the query execution + * that produced this row. + */ +public class CassandraRow { + + private final Row row; + private final RingRange associatedRingRange; + private final ExecutionInfo executionInfo; Review Comment: Now that we store the `ResultSet` in `CassandraSplitState` to keep track of the fetch state, we no more need this `CassandraRow` wrapper as will have the `ExecutionInfo` in the `Resultset` with the call to `RecordEmitter#emitRecord()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
