[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

[GitBox]

JingsongLi commented on code in PR #475:
URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1067684753


##########
flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalog.java:
##########
@@ -408,12 +411,16 @@ private Lock lock(ObjectPath tablePath) {
         return Lock.fromCatalog(lock, tablePath);
     }
 
-    static IMetaStoreClient createClient(HiveConf hiveConf) {
+    static IMetaStoreClient createClient(HiveConf hiveConf, String 
clientClassName) {
         IMetaStoreClient client;
         try {
             client =
                     RetryingMetaStoreClient.getProxy(
-                            hiveConf, tbl -> null, 
HiveMetaStoreClient.class.getName());
+                            hiveConf,

Review Comment:
   We can verify multiple hive versions. I don't know if it is good to all 
supported versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org