XComp commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1061216594
##########
flink-core/src/main/java/org/apache/flink/configuration/HeartbeatManagerOptions.java:
##########
@@ -50,6 +50,8 @@ public class HeartbeatManagerOptions {
private static final String HEARTBEAT_RPC_FAILURE_THRESHOLD_KEY =
"heartbeat.rpc-failure-threshold";
+ public static final int FAILED_RPC_DETECTION_DISABLED = -1;
Review Comment:
Looking at my comment you linked: I see how this can be misunderstood now.
Sorry for that one. 8) I meant "implementation" instead of "production" code.
My initial concern was that I couldn't find any other occurrence where we put
constants next to the `ConfigOption` declarations. It seems like we usually
have them closer to the implementation. Anyway, you have a point with your
arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
