dannycranmer commented on code in PR #21590:
URL: https://github.com/apache/flink/pull/21590#discussion_r1060489104
##########
docs/data/sql_connectors.yml:
##########
@@ -169,22 +169,26 @@ upsert-kafka:
kinesis:
name: Amazon Kinesis Data Streams
category: connector
- maven: flink-connector-kinesis
- sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/$version/flink-sql-connector-kinesis-$version.jar
+ versions:
+ - versions: universal
+ maven: flink-connector-kinesis
+ sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/4.0.0-1.17/flink-sql-connector-kinesis-4.0.0-1.17.jar
Review Comment:
No the `$version` variable is the full version, example, `1.17.0`. We need
the short version. There is background work on improving the shortcodes to deal
with external connectors more graefully
##########
docs/data/sql_connectors.yml:
##########
@@ -169,22 +169,26 @@ upsert-kafka:
kinesis:
name: Amazon Kinesis Data Streams
category: connector
- maven: flink-connector-kinesis
- sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/$version/flink-sql-connector-kinesis-$version.jar
+ versions:
+ - versions: universal
+ maven: flink-connector-kinesis
+ sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/4.0.0-1.17/flink-sql-connector-kinesis-4.0.0-1.17.jar
Review Comment:
No the `$version` variable is the full version, example, `1.17.0`. We need
the short version. There is background work on improving the shortcodes to deal
with external connectors more gracefully
##########
docs/data/sql_connectors.yml:
##########
@@ -169,22 +169,26 @@ upsert-kafka:
kinesis:
name: Amazon Kinesis Data Streams
category: connector
- maven: flink-connector-kinesis
- sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/$version/flink-sql-connector-kinesis-$version.jar
+ versions:
+ - versions: universal
Review Comment:
This version is meant to be the destination version. Since KDS/KDF/DDB are
versionless I have changed to `universal` inline with Kafka. There is
background work on improving the shortcodes to deal with external connectors
more gracefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
