syhily commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060351426
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -236,6 +230,8 @@ private PulsarSourceOptions() {
" This argument is required when
constructing the consumer.")
.build());
+ /** @deprecated This config option is no longer supported. */
+ @Deprecated
public static final ConfigOption<SubscriptionType>
PULSAR_SUBSCRIPTION_TYPE =
Review Comment:
I mean the next 1.18 flink release. We should inform the user first this
method is no longer supported. Then we can remove it. This PR also remove some
deprecated methods and config options which was deprecated in 1.16 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
