yunfengzhou-hub commented on code in PR #193:
URL: https://github.com/apache/flink-ml/pull/193#discussion_r1058213806


##########
flink-ml-benchmark/src/main/resources/stringindexer-benchmark.json:
##########
@@ -17,7 +17,7 @@
   "version": 1,
   "stringindexer100000000": {
     "inputData": {
-      "className": 
"org.apache.flink.ml.benchmark.datagenerator.common.RandStringGenerator",
+      "className": 
"org.apache.flink.ml.benchmark.datagenerator.common.RandomStringGenerator",

Review Comment:
   Let's add a test case to verify that all existing benchmark json files are 
valid. This means the class names correspond to existing classes, and that the 
param maps are reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to