swuferhong commented on code in PR #21530:
URL: https://github.com/apache/flink/pull/21530#discussion_r1058020032
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java:
##########
@@ -135,6 +135,24 @@ public class OptimizerConfigOptions {
.defaultValue(false)
.withDescription("Enables join reorder in optimizer.
Default is disabled.");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_OPTIMIZER_BUSY_JOIN_REORDER =
+ key("table.optimizer.busy-join-reorder")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Enables busy join reorder in optimizer. Default
is disabled.");
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer>
TABLE_OPTIMIZER_BUSY_JOIN_REORDER_DP_THRESHOLD =
+ key("table.optimizer.busy-join-reorder-dp-threshold")
+ .intType()
+ .defaultValue(12)
Review Comment:
> can you explain why we choose `12` as the threshold value ?
New we set the default value to -1, which means that Flink disable busy join
reorder by default. 12 is an empirical parameter provided by the designer of
the algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
