[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548348#comment-15548348
]
ASF GitHub Bot commented on FLINK-4564:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2517
that wouldn't solve the concurrency issues. If you have 2 concurrent
notifies going on you would pass the same FrontMetricGroup to the reporter,
hence for both calls the reporter would work on the same referenced
MetricGroup, even though they may be supposed to be different ones.
I would propose keeping the current approach of creating a new
FrontMetricGroup every time. This means you can simplify that class a lot,
since you can now extend `ProxyMetricGroup`, and pass the index through the
constructor as well. I don't see a solution where we can get away without
creating a new object or putting the entire notification inside a synchronized
block (which would be a no-go).
> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
> Key: FLINK-4564
> URL: https://issues.apache.org/jira/browse/FLINK-4564
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration
> setting shared by all reporters. However, different reporters may have
> different requirements in regards to the delimiter, as such we should allow
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no
> specific setting was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
