pnowojski commented on code in PR #20151:
URL: https://github.com/apache/flink/pull/20151#discussion_r1052319366
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java:
##########
@@ -286,27 +277,32 @@ private void runWithChecks(RunnableWithException r) {
}
}
- public void fail(JobID jobID, JobVertexID jobVertexID, int subtaskIndex,
Throwable e) {
+ /**
+ * The throwable is just used for special subtask, other subtasks should
fail by {@link
+ * CHANNEL_STATE_SHARED_STREAM_EXCEPTION}.
Review Comment:
nit:
> The throwable is just used for specific subtask that triggered the
failure. Other subtasks should fail by {@link
CHANNEL_STATE_SHARED_STREAM_EXCEPTION}
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
