[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648397#comment-17648397 ]
Martijn Visser commented on FLINK-30345: ---------------------------------------- [~masteryhx] Why do you think it's a bug? Based on the given description, this is an optimization (improve performance of serialization). If it's a bug, I would expect a runtime failure or incorrect results. > Improve the serializer performace of state change of changelog > -------------------------------------------------------------- > > Key: FLINK-30345 > URL: https://issues.apache.org/jira/browse/FLINK-30345 > Project: Flink > Issue Type: Bug > Components: Runtime / State Backends > Reporter: Hangxiang Yu > Assignee: Hangxiang Yu > Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > > Currently, AbstractStateChangeLogger use sync > DataOutputViewStreamWrapper to serialize state change which is unnecessary > because it will always be executed in single thread. > So replace it with a unsync one could improve the performance of > serialization. > In my simple stateful WordCount case, it could improve TPS by 10% at least. > Furthermore, because the serialization and deserialization of key and value > have been executed in some delegaed state backend, maybe we could avoid > double serialization. It may improve the performance if the serialization > logic is complex and even is the bottleneck. > This ticket focuses on the sync serializer problem. > The second problem about double serialization could also be disscussed, and I > will create a new ticket if necessary. -- This message was sent by Atlassian Jira (v8.20.10#820010)