[GitHub] [flink] 1996fanrui commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

[GitBox]

1996fanrui commented on code in PR #21498:
URL: https://github.com/apache/flink/pull/21498#discussion_r1048482228


##########
docs/layouts/shortcodes/generated/cluster_configuration.html:
##########
@@ -70,7 +70,7 @@
         </tr>
         <tr>
             <td><h5>cluster.thread-dump.stacktrace-max-depth</h5></td>
-            <td style="word-wrap: break-word;">8</td>
+            <td style="word-wrap: break-word;">24</td>

Review Comment:
   Hi @Myasuka and @yuchen-ecnu , thanks for your contribution. It's a great 
proposal, the 8 is too small for troubleshooting.
   
   However, I'm afraid the 24 is also too small, could you add some information 
about why you set it to 24? I may have missed some information.
   
   we set it to 80 in my company. Because some stacks are too deep, like this: 
   
   
![image](https://user-images.githubusercontent.com/38427477/207609774-c373784c-ebaa-40f1-a985-3d50254668d0.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org