[GitHub] [flink] zhuzhurk commented on a diff in pull request #21388: [FLINK-30188][coordination] Set partition finished state in ConsumedPartitionGroup for dynamic graph correctly.

Wed, 14 Dec 2022 04:02:46 -0800 


zhuzhurk commented on code in PR #21388:
URL: https://github.com/apache/flink/pull/21388#discussion_r1048083776


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java:
##########
@@ -197,10 +202,22 @@ private static ConsumedPartitionGroup 
createAndRegisterConsumedPartitionGroupToE
         ConsumedPartitionGroup consumedPartitionGroup =
                 ConsumedPartitionGroup.fromMultiplePartitions(
                         numConsumers, consumedPartitions, 
intermediateResult.getResultType());
+        finishConsumablePartitions(intermediateResult, consumedPartitions, 
consumedPartitionGroup);
         registerConsumedPartitionGroupToEdgeManager(consumedPartitionGroup, 
intermediateResult);
         return consumedPartitionGroup;
     }
 
+    private static void finishConsumablePartitions(
+            IntermediateResult intermediateResult,
+            List<IntermediateResultPartitionID> consumedPartitionId,

Review Comment:
   consumedPartitionId -> consumedPartitionIds



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java:
##########
@@ -197,10 +202,22 @@ private static ConsumedPartitionGroup 
createAndRegisterConsumedPartitionGroupToE
         ConsumedPartitionGroup consumedPartitionGroup =
                 ConsumedPartitionGroup.fromMultiplePartitions(
                         numConsumers, consumedPartitions, 
intermediateResult.getResultType());
+        finishConsumablePartitions(intermediateResult, consumedPartitions, 
consumedPartitionGroup);
         registerConsumedPartitionGroupToEdgeManager(consumedPartitionGroup, 
intermediateResult);
         return consumedPartitionGroup;
     }
 
+    private static void finishConsumablePartitions(
+            IntermediateResult intermediateResult,
+            List<IntermediateResultPartitionID> consumedPartitionId,
+            ConsumedPartitionGroup consumedPartitionGroup) {
+        for (IntermediateResultPartitionID intermediateResultPartitionID : 
consumedPartitionId) {

Review Comment:
   intermediateResultPartitionID -> consumedPartitionId



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java:
##########
@@ -197,10 +202,22 @@ private static ConsumedPartitionGroup 
createAndRegisterConsumedPartitionGroupToE
         ConsumedPartitionGroup consumedPartitionGroup =
                 ConsumedPartitionGroup.fromMultiplePartitions(
                         numConsumers, consumedPartitions, 
intermediateResult.getResultType());
+        finishConsumablePartitions(intermediateResult, consumedPartitions, 
consumedPartitionGroup);
         registerConsumedPartitionGroupToEdgeManager(consumedPartitionGroup, 
intermediateResult);
         return consumedPartitionGroup;
     }
 
+    private static void finishConsumablePartitions(
+            IntermediateResult intermediateResult,
+            List<IntermediateResultPartitionID> consumedPartitionId,
+            ConsumedPartitionGroup consumedPartitionGroup) {
+        for (IntermediateResultPartitionID intermediateResultPartitionID : 
consumedPartitionId) {
+            if 
(intermediateResult.getPartitionById(intermediateResultPartitionID).isConsumable())
 {

Review Comment:
   +1 to rename `hasDataProduced` to `dataAllProduced`, and rename 
`isConsumable()` to `hasDataAllProduced ()`.
   
   And also remove the legacy `markDataProduced`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to