JingsongLi commented on code in PR #435:
URL: https://github.com/apache/flink-table-store/pull/435#discussion_r1047065211
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/AtMostOnceCommitterOperator.java:
##########
@@ -69,34 +69,24 @@ public class CommitterOperator extends
AbstractStreamOperator<Committable>
private final String initialCommitUser;
/** Group the committable by the checkpoint id. */
- private final NavigableMap<Long, ManifestCommittable>
committablesPerCheckpoint;
Review Comment:
Can we have an interface to describe these logic? Maybe a `CommitRetry`?
In this way, we can have only one `CommitterOperator`. Different
requirements can have different `CommitRetry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
