snuyanzin opened a new pull request, #21500:
URL: https://github.com/apache/flink/pull/21500

   ## What is the purpose of the change
   
   This is a draft version of Janino's upgrade
   In https://github.com/apache/flink/pull/21203 Calcite was updated to 1.28.0
   However Janino was still 3.0.11
   The reason is that there is still of issues on Janino 3.1.x for the fine 
working cases with Janino 3.0.11
   https://github.com/janino-compiler/janino/issues/185
   https://github.com/janino-compiler/janino/issues/187
   https://github.com/janino-compiler/janino/issues/188
   
   Currently it seems that now only one is not fixed (looks like it is fixed 
partially in master)
   There is a workaround for that at 
`org.apache.flink.table.planner.codegen.CodeGenUtils#genToExternalConverterAllWithLegacy`
 (hope it will be fixed soon and workaround will be removed)
   
   ## Verifying this change
   
   It looks like it should be covered by tests in flink-table-planner
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes )
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to