tsreaper commented on code in PR #430:
URL: https://github.com/apache/flink-table-store/pull/430#discussion_r1044089189
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/source/TableStreamingReader.java:
##########
@@ -88,13 +86,7 @@ public TableStreamingReader(
if (predicate != null) {
scan.withFilter(predicate);
}
- enumerator =
- new ContinuousDataFileSnapshotEnumerator(
- table.location(),
- scan,
- new FullStartingScanner(),
- new DeltaFollowUpScanner(),
- null);
+ enumerator = ContinuousDataFileSnapshotEnumerator.create(table, scan,
null);
Review Comment:
What if user set 'scan.mode' = 'from-timestamp' or 'latest' for this table?
The base records wont' be read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
