lindong28 commented on code in PR #183: URL: https://github.com/apache/flink-ml/pull/183#discussion_r1043969902
########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/stopwordsremover/StopWordsRemoverBase.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.feature.stopwordsremover; + +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.BufferedReader; +import java.io.InputStream; +import java.io.InputStreamReader; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Locale; +import java.util.Set; + +/** + * Base class of {@link StopWordsRemover} that contains methods and variables that needs to be + * provided by {@link StopWordsRemover} and also used by {@link StopWordsRemoverParams}. + */ +abstract class StopWordsRemoverBase { Review Comment: Since this class is only subclassed by `StopWordsRemover`, do we still need this class? ########## .github/workflows/python-checks.yml: ########## @@ -28,8 +28,9 @@ jobs: name: python ${{ matrix.python-version }} tests on ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: + fail-fast: false Review Comment: Why should we disable fail-fast? ########## .github/workflows/python-checks.yml: ########## @@ -47,6 +48,9 @@ jobs: - name: Install dependencies working-directory: flink-ml-python/dev run: python -m pip install -r dev-requirements.txt + - name: Install Flink ML + working-directory: flink-ml-python + run: python setup.py sdist && python -m pip install dist/*.tar.gz Review Comment: I am wondering, why we don't need to install Flink ML python library prior to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
