reswqa commented on code in PR #21419:
URL: https://github.com/apache/flink/pull/21419#discussion_r1040712945
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java:
##########
@@ -295,6 +296,14 @@ void cachePartitionInfo(PartitionInfo partitionInfo) {
"Method is not supported in SpeculativeExecutionVertex.");
}
+ @Override
+ protected boolean needMarkPartitionFinished(ResultPartitionType
resultPartitionType) {
+ // for speculative execution, only blocking or hybrid full result
partition need mark
+ // finished.
+ return
resultPartitionType.isBlockingOrBlockingPersistentResultPartition()
+ || resultPartitionType == ResultPartitionType.HYBRID_FULL;
+ }
Review Comment:
Consuming unfinished partitions in speculative mode may be difficult to
support at present, but consuming only finished partitions in non-speculative
mode sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
