1996fanrui commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1337693383
> Thanks for addressing my comments. The PR looks good. 👍 > > @1996fanrui just as hint for future PRs. It helps to add new commits while being in the review process and only do a squash after you're sure that the review is done (usually that can be even done by the committer when merging the PR). Github provides functionality to check the diff after a forced-push. But having separate commits also makes the incremental changes available locally when reviewing the PR using an IDE. Thanks for your reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
