XComp commented on code in PR #21368:
URL: https://github.com/apache/flink/pull/21368#discussion_r1039276265
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java:
##########
@@ -36,52 +35,49 @@
import static
org.apache.flink.runtime.state.ChannelPersistenceITCase.getStreamFactoryFactory;
import static org.apache.flink.util.CloseableIterator.ofElements;
-import static org.apache.flink.util.ExceptionUtils.findThrowable;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** {@link ChannelStateWriterImpl} lifecycle tests. */
-public class ChannelStateWriterImplTest {
+class ChannelStateWriterImplTest {
private static final long CHECKPOINT_ID = 42L;
private static final String TASK_NAME = "test";
- @Test(expected = IllegalArgumentException.class)
- public void testAddEventBuffer() throws Exception {
+ @Test
+ void testAddEventBuffer() throws Exception {
NetworkBuffer dataBuf = getBuffer();
NetworkBuffer eventBuf = getBuffer();
eventBuf.setDataType(Buffer.DataType.EVENT_BUFFER);
- try {
- runWithSyncWorker(
- writer -> {
- callStart(writer);
- writer.addInputData(
- CHECKPOINT_ID,
- new InputChannelInfo(1, 1),
- 1,
- ofElements(Buffer::recycleBuffer, eventBuf,
dataBuf));
- });
- } finally {
- assertTrue(dataBuf.isRecycled());
- }
+
+ runWithSyncWorker(
Review Comment:
I guess, you misunderstood me here: `worker.processAllRequests()` in
[ChannelStateWriterImplTest:319](https://github.com/apache/flink/blob/5596204e67027ff924b97616b5793c8073434412/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java#L319)
is called after the callback function is executed. In the old code, we threw
an Exception within the callback function which resulted in the command in line
319 not being called. In the new version of the code, we rely on
`assertThatThrownBy` which doesn't throw an Exception and, therefore, line 319
is executed, i.e. `worker.processAllRequests()` is called in the expected case.
This feels like an unwanted change? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
