JingsongLi commented on code in PR #410:
URL: https://github.com/apache/flink-table-store/pull/410#discussion_r1039089223
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreScan.java:
##########
@@ -184,10 +203,14 @@ public Plan plan() {
Long snapshotId = specifiedSnapshotId;
if (manifests == null) {
if (snapshotId == null) {
- snapshotId =
- readCompacted
- ? snapshotManager.latestCompactedSnapshotId()
- : snapshotManager.latestSnapshotId();
+ if (timestampMills == null) {
+ snapshotId =
+ readCompacted
+ ?
snapshotManager.latestCompactedSnapshotId()
+ : snapshotManager.latestSnapshotId();
+ } else {
+ snapshotId =
snapshotManager.earlierThanTimeMills(timestampMills);
Review Comment:
Maybe we should use `earlier Than or equals`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
