hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036848127
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields,
DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value
-> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
@luoyuxia what if to add a method to indenify format in HiveTableSource, and
when implement applyFilter, we can get this format info, so to better implement
applyFilter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
