[GitHub] [flink] WeiZhong94 commented on a diff in pull request #21429: [FLINK-30245][table-runtime] Fix the NPE thrown when filtering decimal(18, x) values after calling DecimalDataUtils.subtract method.

[GitBox]

WeiZhong94 commented on code in PR #21429:
URL: https://github.com/apache/flink/pull/21429#discussion_r1036654186


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/DecimalDataUtils.java:
##########
@@ -104,7 +105,10 @@ public static DecimalData ceil(DecimalData decimal) {
     }
 
     public static DecimalData add(DecimalData v1, DecimalData v2, int 
precision, int scale) {
-        if (v1.isCompact() && v2.isCompact() && v1.scale == v2.scale) {
+        if (v1.isCompact()
+                && v2.isCompact()
+                && v1.scale == v2.scale
+                && precision <= MAX_COMPACT_PRECISION) {

Review Comment:
   Updated



##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/DecimalDataUtils.java:
##########
@@ -118,7 +122,10 @@ public static DecimalData add(DecimalData v1, DecimalData 
v2, int precision, int
     }
 
     public static DecimalData subtract(DecimalData v1, DecimalData v2, int 
precision, int scale) {
-        if (v1.isCompact() && v2.isCompact() && v1.scale == v2.scale) {
+        if (v1.isCompact()
+                && v2.isCompact()
+                && v1.scale == v2.scale
+                && precision <= MAX_COMPACT_PRECISION) {

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org